Skip to content

ci(warm-deps): key cache on pristine lock hash so fork restores hit (#831) #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikrantpuppala wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(warm-deps): key cache on pristine lock hash so fork restores hit (#831) #850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/warm-deps-cache.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,18 @@ jobs:
git checkout FETCH_HEAD -- poetry.lock pyproject.toml
echo "Overlaid poetry.lock / pyproject.toml from the fork branch."

# Capture the lock hash from the PRISTINE, committed poetry.lock BEFORE
# setup-poetry runs (it calls `poetry lock`, which rewrites poetry.lock
# in place and changes hashFiles's result). restore-deps in the PR jobs
# hashes the pristine lock, so the warmer MUST hash it at the same point
# or the keys never match and every fork restore misses.
- name: Capture pristine lock hash
id: lockhash
run: |
set -euo pipefail
echo "value=${{ hashFiles('**/poetry.lock') }}" >> "$GITHUB_OUTPUT"
echo "Pristine poetry.lock hash: ${{ hashFiles('**/poetry.lock') }}"

- name: Install Kerberos system dependencies
if: matrix.extras == 'pyarrow' || matrix.extras == 'kernel'
run: |
Expand Down Expand Up @@ -186,7 +198,9 @@ jobs:
run: |
set -euo pipefail
TIMESTAMP=$(date -u +%Y%m%d%H%M%S)
LOCK_HASH="${{ hashFiles('**/poetry.lock') }}"
# Pristine hash captured BEFORE setup-poetry's `poetry lock` mutated
# the file — matches what restore-deps computes in the PR jobs.
LOCK_HASH="${{ steps.lockhash.outputs.value }}"
PY="${{ matrix.python-version }}"
DEP="${{ matrix.dependency-version }}"
EXTRAS="${{ matrix.extras || 'base' }}"
Expand Down
Loading