ci(warm-deps): key cache on pristine lock hash so fork restores hit (#831)#850
Open
vikrantpuppala wants to merge 1 commit into
Open
ci(warm-deps): key cache on pristine lock hash so fork restores hit (#831)#850vikrantpuppala wants to merge 1 commit into
vikrantpuppala wants to merge 1 commit into
Conversation
…831) The warmer computed its cache key with hashFiles('**/poetry.lock') AFTER setup-poetry ran `poetry lock`, which rewrites poetry.lock in place. The PR jobs' restore-deps hashes the PRISTINE committed poetry.lock (it runs before setup-poetry). The two hashes therefore never matched — a fork PR looked up e.g. forkvenv-...-46e4852b... while the warmer had saved forkvenv-...-143cf261... so every fork restore missed and fell back to the JFrog path (which forks can't auth to), failing all jobs. Capture the pristine lock hash in a step BEFORE setup-poetry and use that for the cache key, matching what restore-deps computes. Found via the fork verification PR #849 (all Unit Tests legs missed the cache). Refs #831 Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second follow-up to #845 (after #848). The fork verification PR (#849) surfaced that every
Unit Testsleg missed the prewarmed cache and fell back to the JFrog path (which forks can't authenticate to), failing the jobs.Root cause: a lockfile-hash mismatch between warmer and consumer.
setup-poetryrunspoetry lock, which rewritespoetry.lockin place.hashFiles('**/poetry.lock')aftersetup-poetry→ hash143cf261….restore-deps(PR jobs) hashes the pristine committedpoetry.lock(it runs beforesetup-poetry) → hash46e4852b….The two never matched, so every fork restore missed:
(warmer had saved
forkvenv-Linux-3.9-min-base-143cf261…).Fix: capture the pristine lock hash in a step before
setup-poetryand use that for the cache key, matching whatrestore-depscomputes.Test plan
main, then re-run the fork verification PR (test: verify fork-PR CI runs offline from prewarmed cache (#831) [DO NOT MERGE] #849) and confirm all Unit/lint/type legs restore the cache and run offline (no JFrog).Refs #831
This pull request and its description were written by Isaac.