ci(warm-deps): fix empty --extras on base matrix legs (#831)#848
Merged
Conversation
The install-args expression used `matrix.extras == '' && '' || format(...)`. GitHub Actions treats the empty-string middle operand as falsy, so the base leg (extras='') fell through to the format() branch and produced `--extras ` with no value, failing `poetry install` with 'The "--extras" option requires a value'. Only the base legs failed; pyarrow/kernel legs (non-empty extras) passed. Invert to test for non-empty extras first and default to '', which never yields a valueless --extras. Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com> Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
vikrantpuppala
force-pushed
the
fix/831-warmer-extras-ternary
branch
from
c8a73aa to
a8f7ed9
Compare
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #845. The warmer's first dispatch failed on all
extras=baselegs with:Root cause: the
install-argsexpression wasmatrix.extras == '' && '' || format('--extras {0}', matrix.extras). GitHub Actions'A && B || Ctreats the empty-string middle operand''as falsy, so the base leg fell through to theformat(...)branch and emitted--extraswith no value. pyarrow/kernel legs (non-emptyextras) were unaffected — which is exactly the observed split.Fix: test for non-empty extras first, default to
'':Test plan
mainafter this merges; confirm all 25 legs (incl. base) succeed and saveforkvenv-*caches. Then verify a fork PR restores them.Refs #831
This pull request and its description were written by Isaac.