Skip to content

acc: suppress bare "Warn: retrying" lines in acceptance output #7339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pietern wants to merge 1 commit into from
Closed

acc: suppress bare "Warn: retrying" lines in acceptance output #7339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions acceptance/selftest/suppresslines/keep/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ Signal: before
Noise: 1
Signal: after
Warn: deploying resources.jobs.foo: retrying after 500 Internal Server Error from GET /api
Warn: retrying
1 change: 1 addition & 0 deletions acceptance/selftest/suppresslines/keep/script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ echo "Signal: before"
echo "Noise: 1"
echo "Signal: after"
echo "Warn: deploying resources.jobs.foo: retrying after 500 Internal Server Error from GET /api"
echo "Warn: retrying"
1 change: 1 addition & 0 deletions acceptance/selftest/suppresslines/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
Signal: before
Signal: after
Warn: something failed; retrying in 5s
3 changes: 3 additions & 0 deletions acceptance/selftest/suppresslines/script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ echo "Signal: before"
echo "Noise: 1"
echo "Signal: after"
echo "Warn: deploying resources.jobs.foo: retrying after 500 Internal Server Error from GET /api"
echo "Warn: retrying"
echo "Warn: planning resources.jobs.foo: retrying"
echo "Warn: something failed; retrying in 5s"
3 changes: 2 additions & 1 deletion acceptance/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ SortLines.deploy_actions = '^(Created|Updated|Deleted|Recreated|Resized) \S+$'
# Retries are timing dependent, so their warnings would make output flaky. They go to the
# test log instead. A test that injects errors deterministically and asserts the warning
# sets SuppressLines.warn_retry = "".
SuppressLines.warn_retry = '^Warn: .*retrying after '
# Transport errors such as REFUSED_STREAM carry no status code, so their warning is a bare "retrying".
SuppressLines.warn_retry = '^Warn: .*retrying( after |$)'

# >>> datetime.datetime.fromtimestamp(18000000000)
# datetime.datetime(2027, 1, 15, 9, 0)
Expand Down
Loading