Repository navigation
Conversation
retryMessage only adds "after <status>" for API errors. Transport errors that IsTransientRead retries (REFUSED_STREAM, unexpected EOF) log a bare "Warn: retrying", which the warn_retry pattern from #7192 did not match, so these timing-dependent warnings leaked into cloud test output. Extend the pattern to match the bare form too and cover it in the suppresslines selftest. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Contributor
why is it a gap? the same reason for "retry after" applies here as well, no? this make tests more stable. Warning is still logged btw, it is not lost. |
Contributor
Author
|
You're right, this could have been fixed with another pattern in the root Can be done when it actually happens. |
Contributor
|
Sorry I misread it -- this extends the pattern, not narrows it down. In that case, we should apply it. Could be separate named pattern, but not required. |
Contributor
Author
|
It is hypothetical though, we haven't seen this pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#7192 replaced the env var that silenced retry warnings in acceptance tests with
SuppressLines.warn_retry = '^Warn: .*retrying after '.retryMessageonly adds "after " for*apierr.APIError; transport errors thatIsTransientReadretries (REFUSED_STREAM, unexpected EOF) print a bareWarn: retrying, so on cloud runs those lines reached the compared output.The pattern is now
'^Warn: .*retrying( after |$)'. The$anchor keeps unrelated warnings visible, such as the SSH keepalive's "retrying in 5s".Why
Gap in the acceptance retry-warning filter added in #7192.
Tests
acceptance/selftest/suppresslinesnow emitsWarn: retryingandWarn: planning resources.jobs.foo: retrying(suppressed) andWarn: something failed; retrying in 5s(kept); thekeep/variant shows the line with suppression off. Fails with the old pattern.go test ./libs/retry/... ./libs/testdiff/... ./acceptance/internal/...; local acceptancebundle/deploy,selftest,cmd/sync,bundle/sync,bundle/upload,bundle/resources/permissions;task fmt-q/lint-q.This pull request and its description were written by Isaac.