Repository navigation
acc: replace retry-warning env var with SuppressLines - #7192
Merged
Merged
Conversation
…s by default Instead of disabling the retry warning in the CLI, the acceptance runner moves lines matching SuppressLines patterns from the compared output to the test log. Tests that assert the warning disable the named pattern with an empty value. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 7 changed tests (limit=20, 0 not selected) 10 tests: regression=0 unreleased=0 coverage=10 failing=0
|
denik
changed the title
denik
marked this pull request as ready for review
October 27, 2026 11:39
Collaborator
Integration test reportCommit: b97d823
Top 6 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Oct 27, 2026
Collaborator
Integration test reportCommit: 6afbb24
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Better for error analysis to see the warnings & can be extended to other & flaky output instead of grepping it out.
Changes
Follow-up to #7149
Instead of an env var that disables the retry warning in the CLI, the acceptance runner gets
SuppressLines: lines matching a named pattern are removed from the compared output and written to the test log. Roottest.tomlsetsSuppressLines.warn_retry; the 6 tests that assert the warning set it to"". RevertsDATABRICKS_BUNDLE_RETRY_DISABLE_WARNING.This pull request and its description were written by Isaac.