Repository navigation
Conversation
Collaborator
Integration test reportCommit: 1941ff7
Top 6 slowest tests (at least 2 minutes):
|
A failed Terraform state conversion returned with the temp state's WAL still open, so removing it failed on Windows and left the files until the next run. Add DeploymentState.Discard (close without persisting, remove the file and WAL) and dstate.RemoveFiles, and use them for the migration's temp state. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/migrate-discard-temp-state
branch
from
October 12, 2026 10:53
4380709 to
1941ff7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting Terraform state to the direct engine failed after the temp state's WAL was opened, the conversion returned with the WAL handle still open, so removing the temp files failed on Windows and left them until the next run. Adds
DeploymentState.Discard(close without persisting, then remove the state file and its WAL) anddstate.RemoveFiles, and uses them for the auto-migration's temp state. #6973 will reuseDiscardforbundle deployment migrate.This pull request and its description were written by Isaac.