Skip to content

bundle: clean up the migration WAL when deployment migrate fails - #6973

Draft
denik wants to merge 5 commits into
denik/migrate-discard-temp-statefrom
denik/tf-migrate-wal-cleanup
Draft

denik wants to merge 5 commits into
denik/migrate-discard-temp-statefrom
denik/tf-migrate-wal-cleanup

Conversation

@denik

@denik denik commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #6977.

When bundle deployment migrate failed after creating its temp state's WAL (e.g. on an unresolvable reference), it removed only the temp state file, so every retry failed with "failed to open WAL file ... file exists". The cleanup now uses DeploymentState.Discard from #6977, which closes the WAL handle (required on Windows) and removes both files. Adds bundle/migrate/command/retry-after-failure.

This pull request and its description were written by Isaac.

@github-actions github-actions Bot added the DABs DABs related issues label Oct 7, 2026
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: a89834b

Run: 38239950096

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 276 17 5:52
✅​ aws-windows-latest-4core-16gb 278 15 3:36
✅​ azure linux-2core-8gb 275 17 6:12
✅​ azure-windows-latest-4core-16gb 277 15 3:45
✅​ gcp linux-2core-8gb 276 17 6:39
✅​ gcp-windows-latest-4core-16gb 278 15 3:38
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:06 azure linux-2core-8gb TestAccept
4:00 aws linux-2core-8gb TestAccept
3:59 gcp linux-2core-8gb TestAccept
3:43 azure-windows-latest-4core-16gb TestAccept
3:35 gcp-windows-latest-4core-16gb TestAccept
3:34 aws-windows-latest-4core-16gb TestAccept

@denik
denik force-pushed the denik/tf-migrate-wal-cleanup branch from 58e038d to 5654221 Compare October 7, 2026 12:35
@denik
denik changed the base branch from main to denik/migrate-discard-temp-state October 7, 2026 12:35
@denik
denik force-pushed the denik/migrate-discard-temp-state branch from 4380709 to 1941ff7 Compare October 12, 2026 10:53
@denik
denik force-pushed the denik/tf-migrate-wal-cleanup branch from 5654221 to 5e0b9eb Compare October 12, 2026 10:53
denik and others added 5 commits October 14, 2026 16:33
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik force-pushed the denik/migrate-discard-temp-state branch from 1941ff7 to 9788566 Compare October 14, 2026 14:34
@denik
denik force-pushed the denik/tf-migrate-wal-cleanup branch from a89834b to 90268b1 Compare October 14, 2026 14:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants