Repository navigation
Apply account repository policy #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,22 +33,12 @@ permissions: | |
| discussions: write | ||
| pull-requests: write | ||
|
|
||
| # Copilot Triage's own workflow does the rest, and updates with its v0 tag. | ||
| jobs: | ||
| assess: | ||
| if: vars.COPILOT_ISSUE_ASSESSMENT_ENABLED == 'true' && (github.event.sender.type != 'Bot' || github.event_name == 'issues' || github.event_name == 'pull_request_review') | ||
| # On the job, so a bot comment's skipped run never replaces a queued one. | ||
| concurrency: | ||
| group: >- | ||
| assessment-${{ github.event.discussion && 'discussion' || inputs.kind || 'issue' }}-${{ github.event.issue.number || github.event.discussion.number || github.event.pull_request.number || inputs.number }}-${{ github.event.discussion && (github.event.comment.parent_id || github.event.comment.id) || 'report' }} | ||
| cancel-in-progress: false | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - uses: crmne/copilot-triage@v0 | ||
| with: | ||
| copilot-token: ${{ secrets.COPILOT_GITHUB_TOKEN }} | ||
| fallback-api-key: ${{ secrets.OPENROUTER_API_KEY }} | ||
| project-token: ${{ secrets.TRIAGE_PROJECT_TOKEN }} | ||
| kind: ${{ inputs.kind || (github.event.discussion && 'discussion' || (github.event.pull_request || github.event.issue.pull_request) && 'pull_request' || 'issue') }} | ||
| number: ${{ inputs.number || github.event.issue.number || github.event.discussion.number || github.event.pull_request.number }} | ||
| dry-run: ${{ inputs.dry_run || false }} | ||
| triage: | ||
| uses: crmne/copilot-triage/.github/workflows/assess.yml@v0 | ||
|
Comment on lines
+38
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Restore the assessment enable gate. When 🧰 Tools🪛 zizmor (1.30.1)[warning] 39-39: secrets unconditionally inherited by called workflow (secrets-inherit): this reusable workflow (secrets-inherit) 🤖 Prompt for AI Agents |
||
| secrets: inherit | ||
| with: | ||
| kind: ${{ inputs.kind || '' }} | ||
| number: ${{ inputs.number || '' }} | ||
| dry_run: ${{ inputs.dry_run || false }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Restore the assessment flag check if it still disables board automation.
The scheduled
sweepjob no longer checksCOPILOT_ISSUE_ASSESSMENT_ENABLED. If that flag is disabled whileTRIAGE_PROJECT_TOKENremains set, the called sweep can still change board cards and dispatch issue assessments. The called workflow does not check the flag. Restore the job condition unless this change intentionally retires that control. (raw.githubusercontent.com)🧰 Tools
🪛 zizmor (1.30.1)
[warning] 21-21: secrets unconditionally inherited by called workflow (secrets-inherit): this reusable workflow
(secrets-inherit)
🤖 Prompt for AI Agents