Skip to content

Keep deleted husk packages off the tree #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Sep 10, 2026
+58 −0
Merged

Keep deleted husk packages off the tree #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions scripts/checks/replaced-paths.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,21 @@ scripts/checks/growth.ts
scripts/checks/manifest.ts
scripts/checks/routes.ts
scripts/checks/lib/modules.ts
packages/agent-workflow-authoring
packages/cli
packages/echo
packages/folded-run-one-shot
packages/folded-runs
packages/hub-client
packages/routines
packages/routines-tools
packages/sidecar-placement
packages/task-dispatch-tools
packages/task-planner
packages/tasks
packages/tasks-ui
packages/workflow-catalog
packages/workflow-deploy-source
packages/workflow-freeze
packages/workflow-host-actions
packages/workflow-source
40 changes: 40 additions & 0 deletions scripts/checks/test/deletion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { existsSync, readFileSync } from "node:fs";
import path from "node:path";
import { expect, test } from "bun:test";
import { auditReplacedPaths, parseLedger } from "../deletion";

Expand Down Expand Up @@ -27,3 +29,41 @@ test("only the surviving paths are reported", () => {
expect(report.violations).toHaveLength(1);
expect(report.violations[0]).toContain("alive.ts");
});

// Empty leftover package dirs from the installer review (13) plus five more
// found at pickup. Git already dropped them; the replacement ledger keeps
// them from coming back as workspace members.
const DELETED_HUSK_PACKAGES = [
"packages/agent-workflow-authoring",
"packages/cli",
"packages/echo",
"packages/folded-run-one-shot",
"packages/folded-runs",
"packages/hub-client",
"packages/routines",
"packages/routines-tools",
"packages/sidecar-placement",
"packages/task-dispatch-tools",
"packages/task-planner",
"packages/tasks",
"packages/tasks-ui",
"packages/workflow-catalog",
"packages/workflow-deploy-source",
"packages/workflow-freeze",
"packages/workflow-host-actions",
"packages/workflow-source",
];

test("deleted husk packages stay on the replacement ledger and are gone", () => {
const repoRoot = path.resolve(import.meta.dir, "../../..");
const ledger = parseLedger(
readFileSync(
path.join(repoRoot, "scripts/checks/replaced-paths.txt"),
"utf8",
),
);
for (const husk of DELETED_HUSK_PACKAGES) {
expect(ledger).toContain(husk);
expect(existsSync(path.join(repoRoot, husk))).toBe(false);
}
});
Loading