Keep deleted husk packages off the tree - #700
Merged
Merged
Conversation
Git already dropped these empty leftover package directories. The replacement ledger is how the deletion check keeps them from coming back as workspace members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: CL-7577
Summary
These empty leftover package directories are already gone from git. This PR records them on the replacement ledger so
check:deletionkeeps them from coming back as workspace members.Installer review named 13. Pickup found five more empty leftover dirs (
cli,echo,routines,routines-tools,sidecar-placement). All 18 were empty (nopackage.json, no git-tracked source). None are live re-export husks.packages/agent-workflow-authoringpackages/clipackages/echopackages/folded-run-one-shotpackages/folded-runspackages/hub-clientpackages/routinespackages/routines-toolspackages/sidecar-placementpackages/task-dispatch-toolspackages/task-plannerpackages/taskspackages/tasks-uipackages/workflow-catalogpackages/workflow-deploy-sourcepackages/workflow-freezepackages/workflow-host-actionspackages/workflow-sourceA local clone that still has one of these dirs as leftover
node_modules/distwill failcheck:deletionuntil that directory is removed. That is intended.Does not touch hub boot or
apps/hub/src/index.ts.Test plan
bun test scripts/checks/test/deletion.test.tsbun run check:structural deletionbun run check