Repository navigation
test(stories): add sample conversations for the chat stories - #117
Open
pratikbuilds wants to merge 2 commits into
Open
pratikbuilds wants to merge 2 commits into
pratikbuilds wants to merge 2 commits into
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Stacked on #116: only this pull request's own changes were checked. Notes:
|
pratikbuilds
force-pushed
the
conversation/02-samples
branch
from
October 22, 2026 14:34
426edca to
1f29a63
Compare
pratikbuilds
force-pushed
the
conversation/02-samples
branch
from
October 22, 2026 16:23
1f29a63 to
05fc47b
Compare
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Automated multi-agent review: independent review + second-agent validation of every flag; only confirmed items listed. Everything below is minor and verified by running the helper.
- minor
stories/chat/samples/play-turn.ts:49-60— a queued call (status: "pending", no approval record) replays as running first, then regresses to pending:toolStagesonly short-circuitsapproval-requestedandrunning, so bare queued traces fall through to the synthetic-running branch (verified repro). Addpart.status === "pending"to the no-stage branch plus a regression test asserting a queued call never showsrunningbefore its final frame. - minor
stories/chat/samples/play-turn.ts:100—turnFramescan emit a duplicate no-op frame after a tool batch whose last call contributes no stage (finalrunning/approval-requestedwith no record makesstarted[last]equal the settled form; verified). Fix: skip a frame whose parts equal the previous frame's, or stop the batch loop one short.
pratikbuilds
force-pushed
the
conversation/02-samples
branch
from
October 27, 2026 13:25
05fc47b to
42b5877
Compare
Collaborator
Author
|
Thanks for the review. Both points are fixed. 1. A queued call replayed as running first, then went back to pending (minor)
2. A tool batch could produce a duplicate frame (minor)
Commit: |
pratikbuilds
force-pushed
the
conversation/02-samples
branch
from
October 27, 2026 13:54
42b5877 to
9796dc0
Compare
TheGreatAxios
approved these changes
Oct 27, 2026
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Review · Approve
Adds sample conversations and a play-turn helper for the chat stories.
Findings
No findings.
Add deterministic samples built only from the conversation contract: a short chat, a 300-message history, a tool storm with a batch, a failure and every approval outcome, generated images, a thread and a failed send. playTurn reveals a message's parts over time for streaming stories. Images are inline SVG, timestamps are fixed, and nothing reads the clock or Math.random.
The sample replay gave a queued call (pending, no approval record) a synthetic running frame, so it ran and then went back to pending. It is now shown queued from the start, like a waiting or running call. A tool batch also emitted one frame per call, so a call with no earlier form produced a frame identical to the one before it. The batch now finishes only the calls that change, one at a time, and leaves the rest in their final form, so every frame differs from the previous one.
pratikbuilds
force-pushed
the
conversation/02-samples
branch
from
October 28, 2026 08:41
9796dc0 to
475d220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deterministic samples built only from the conversation contract: a short chat, a 300-message history, a tool storm with a batch, a failure and every approval outcome, generated images, a thread and a failed send. playTurn reveals a message's parts over time for streaming stories. Images are inline SVG, timestamps are fixed, and nothing reads the clock or Math.random.
Stacked on #116: review only this commit. Part of #94.
Notes for review
bun test stories/chat/samples;bun run testonly covers src/.Verification
bun run typecheckandbun run linton its own (the stack is checked commit by commit).bun run check,bun run build,bun run dep-guard,bun run contrast-testandbun run test:e2e(Playwright specs and the Storybook axe sweep in light and dark) pass.Closes #96