Skip to content

test(stories): add sample conversations for the chat stories - #5

Closed
pratikbuilds wants to merge 1 commit into
conversation/12-panelfrom
conversation/02-samples
Closed

pratikbuilds wants to merge 1 commit into
conversation/12-panelfrom
conversation/02-samples

Conversation

@pratikbuilds

Copy link
Copy Markdown
Owner

Add deterministic samples built only from the conversation contract: a short chat, a 300-message history, a tool storm with a batch, a failure and every approval outcome, generated images, a thread and a failed send. playTurn reveals a message's parts over time for streaming stories. Images are inline SVG, timestamps are fixed, and nothing reads the clock or Math.random.

Stacked on #4: review only this commit. Part of corbitsdev#94.

Notes for review

  • Sample unit tests live beside the samples under stories/ and run with bun test stories/chat/samples; bun run test only covers src/.
  • Streaming stories built on playTurn should start paused or play on a user action: the axe sweep waits for CSS animations, not timers.
  • Follow-up: stories/chat/conversation.stories.tsx still has its own placeholder history; move it onto the samples when it first renders contract messages.

Verification

  • This commit passes bun run typecheck and bun run lint on its own (the stack is checked commit by commit).
  • At the top of the stack: bun run check, bun run build, bun run dep-guard, bun run contrast-test and bun run test:e2e (Playwright specs and the Storybook axe sweep in light and dark) pass.

Closes corbitsdev#96

Add deterministic samples built only from the conversation contract:
a short chat, a 300-message history, a tool storm with a batch, a
failure and every approval outcome, generated images, a thread and a
failed send. playTurn reveals a message's parts over time for streaming
stories. Images are inline SVG, timestamps are fixed, and nothing reads
the clock or Math.random.
@pratikbuilds

Copy link
Copy Markdown
Owner Author

Moved upstream: corbitsdev#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant