Repository navigation
refactor(hub): delete the worker coordinator, rotation and code review feed - #641
Merged
TheGreatAxios merged 4 commits intoOct 26, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-11525-route-every-pull-request-through-the-listener
branch
from
October 26, 2026 19:22
35b9d04 to
c3aeee0
Compare
TheGreatAxios
force-pushed
the
cl-11525-delete-the-worker-coordinator-and-code-review-feed
branch
from
October 26, 2026 19:22
bf59171 to
b0e5488
Compare
TheGreatAxios
force-pushed
the
cl-11525-delete-the-worker-coordinator-and-code-review-feed
branch
from
October 26, 2026 19:39
b0e5488 to
e4db003
Compare
…onnected host's listener
…ntial is replaced
TheGreatAxios
changed the base branch from
cl-11525-route-every-pull-request-through-the-listener
to
main
October 26, 2026 20:13
TheGreatAxios
marked this pull request as ready for review
October 26, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CL-11525. Second of five stacked PRs that remove the old pr-triage path. Since the first PR, every pull request goes through the listener, so the hub code that ran the old path has nothing left to do. This PR deletes it.
Why
The worker queue, deployment rotation and heal, and the standalone code review feed only served the old path. Keeping them around means keeping code that can never run.
What changed
Removed the job coordinator, worker spawning and the orphaned-worker release at boot.
Removed deployment rotation and heal, and their tenant-config record.
Disconnecting a host now releases that host's listener and its managers through the stock cancel. A Bitbucket Data Center disconnect does it right away. Removing the GitHub App credential does it on the next reconcile pass, because the stock credential route does not notify the hub.
Removed the code review feed and the head-carry check that only the feed used.
Moved the pull request reader and the review request builder (
reviewRequestOf,diffHash,cutDiff) intopull-request-reader.ts.Moved the
TriageJobtype intotriage-queue.tsand dropped its unusedworkflowandsourcefields.Removed the GitHub token "ensure before a worker deploys" step. The renewal loop still renews tokens.
Bitbucket host check: it used to run before a worker was spawned. It now runs before any mail goes to a Bitbucket listener or manager (
checkedBitbucketDelivery). A host that is no longer allowed gets no mail.Upgrade now also cancels every live deployment of the workflows the listener replaced: pr-triage, pr-triage-historical, the standalone code review and the PR workflow variants.
The portal no longer deploys workflows on load or after saving a key. It deployed only the workflows Upgrade cancels. Removed with it:
ensureWorkflowsand the registry sync;Upgrade now sets the tenant's deployment lifetime itself.
After a credential is replaced, the portal restarts that host's listener: it deploys the newest listener again from the same asset commit, without republishing, then cancels the older ones the way Upgrade does. The workflow-versions route now reports each source deployment's asset and commit (
source) so the portal can do this. Managers and judges launch with the current value, so nothing else restarts.Removed the per-repository code review switch from the repository page, since nothing reads the setting any more. The page now shows only Code review needs an isolated place to run when there is no place to run. Slice 4 removes the hub route and the record's
codeReviewfield.A backlog for a repository with no open pull request that is not a draft is accepted with nothing to do. Before, it answered as if Triage were stopped.
When a gate read fails partway through a mail, the pull requests recorded before it still go to the listener.
Dropped the portal's unread
prWorkflowSources.Nothing deploys a listener on its own: not when a host is connected after the last upgrade, not when a decision model is saved from Settings, and not when someone who cannot upgrade finishes onboarding. Settings then says Triage is stopped until it is upgraded and shows the button. The manual's upgrade section says so.
ARCHITECTURE.md, IMPLEMENTATION.md, BITBUCKET_DATACENTER.md and the user manual are updated. The code review sections now say code review runs with triage when the policy file turns it on, or on Review again.
Verified
bun run check,bun run lintand the policy check pass.