Repository navigation
refactor(hub): read verdicts and catch-up from the managers - #644
Merged
Merged
Conversation
…te the run-log recorder
…stats through the manager's verdict
TheGreatAxios
marked this pull request as ready for review
October 26, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CL-11525. Third of the stacked PRs that remove the old pr-triage path.
Why
Every pull request now runs in a manager, but the reconciler, the verdict list and the catch-up status still read pr-triage's run logs. Nothing writes those logs any more.
What changed
triage-runs.tskeeps only what held Dos and the audit log read from a run's log: its verdict and its approval.unknownfor a run, so the contract drops that status;withWorkflowVersions. This is intended: a head that used up its attempts no longer gets another try after an upgrade. Triage again covers it.judgedin facts, rules, parts and evaluate) is left to slice 5, because changing it changes how the workflow judges and needs an eval.run-logs.ts,useRuns, the run-log query keys and their persistence.The Bitbucket host check test asked for in this slice landed in #641.
The policy check flags three
?? []lines. Each one means there is nothing yet: no recorded runs for a head, or no verdict list loaded. Each matches an existing line next to it.Verified
bun run check,bun run lintand the policy check pass, apart from the three lines above.server.test.tsnow records its verdicts the way a manager's pass does (summaryOfandreplaceVerdict).