Heal torn base tails on write and keep failed rewrite commits on HEAD - #899
Merged
Conversation
TheGreatAxios
force-pushed
the
fix-session-store-test-failures
branch
from
September 11, 2026 02:43
36fadb5 to
2c7db78
Compare
TheGreatAxios
force-pushed
the
fix-session-store-test-failures
branch
from
September 11, 2026 03:07
2c7db78 to
96066e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeTurnsno longer crashes on a torn or poisonedturns.jsonlbase tail — it falls back to the same resilient on-disk parseload()uses, so the write that heals the file can actually runload()to serve.git/hooks/*) by replacing.git/objectswith a regular file — the previouscommit-msghook mechanism could never fail the commit it claimed to exerciseassemble-runtimetests mockcreateSessionStores— the boundarybuildAgentactually calls since the store-factory split — instead of the innercreateOptimizedContextStorethat no longer runs thereTest plan
bun test src/session/optimized-context-store.test.ts src/session/assemble-runtime.test.ts— 40 passbun test ./src/session— 206 passbun run typecheck— clean