Reconcile extra session segments before skipping empty checkpoints - #901
Merged
TheGreatAxios merged 1 commit intoSep 11, 2026
Merged
Conversation
Skip used the in-memory pending set, so extra turn and prompt segments left on disk after a crash never entered the managed-path diff and were left untracked.
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Comment
Empty-checkpoint skip runs after reconcileSegmentStaging so leftover extra turn/prompt segments are staged. Skip still fires only when stagedRewrite is null.
Findings
No findings.
Notes
src/session/optimized-context-store.ts:763-793— reconcile, then skip; extras land intoAddandmanagedPathsDifferpartial.jsonlstays off the managed allowlist; #899 torn-base write and failed-rewrite restore still pass
TheGreatAxios
deleted the
cl-7701-empty-checkpoint-skip-can-leave-extra-turn-segments
branch
September 11, 2026 04:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run typecheck,bun run build, andbun run testpassbun test ./src/session/optimized-context-store.test.tspasses (37 tests)Fixes CL-7701