Skip to content

test(variables): generate delivery-token fixtures at runtime - #246

Merged
Harshi-Shah-CS merged 1 commit into
v2-devfrom
cl-7169
Oct 22, 2026
Merged

Harshi-Shah-CS merged 1 commit into
v2-devfrom
cl-7169

Conversation

@Harshi-Shah-CS

Copy link
Copy Markdown
Contributor

What

Follow-up to #245 (CL-7169), which merged before this review finding landed.

The unit tests for the variables and stacks modules hardcoded token-shaped literals (cs-secret-token, cs-prod-value, cs-saved-value, cs-aaa and similar). They are now built with randomUUID(), as the integration tests already do, so no fixed token-shaped string is committed and the leak assertions compare against the generated value. Test files only: variable.set, variable.stack, variable.create and stacks.api. The four .talismanrc checksums are refreshed for them.

Tests

  • Full suite on the branch: 138 suites, 2,380 tests, all passing; the Talisman and trufflehog pre-push scans pass.

#claude_code#
🤖 Generated with Claude Code

The unit tests for the variables and stacks modules hardcoded
token-shaped literals such as cs-secret-token and cs-prod-value. Build
them with randomUUID() instead, so no fixed token-shaped string is
committed and the leak assertions compare against the generated value.
The four .talismanrc checksums are refreshed for the changed files.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Harshi Shah <harshi.shah@contentstack.com>
@Harshi-Shah-CS
Harshi-Shah-CS requested a review from a team as a code owner October 22, 2026 06:01
@snyk-io

snyk-io Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 9 25 ✅ Passed
🟡 Medium Severity 0 3 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 9
  • Medium without fixes: 3
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@Harshi-Shah-CS
Harshi-Shah-CS merged commit 455848e into v2-dev Oct 22, 2026
7 checks passed
@Harshi-Shah-CS
Harshi-Shah-CS deleted the cl-7169 branch October 22, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants