Repository navigation
fix(variables): split a variable at the first separator and raise when a stack lookup cannot finish - #249
Merged
Conversation
…n a stack lookup cannot finish Follow-up to review of #245 and #247. parseAssignment now splits at whichever of "=" and ":" comes first, so a value may hold the other one: API_URL:https://x.test?a=b is the key API_URL and the whole URL, where it used to split at the later "=". The stack and delivery-token lookups behind --from-stack stopped silently after 100 pages and returned a truncated list. They now raise CmaScanLimitError, as every other scan that cannot finish does. AGENTS.md says what a code with no message entry falls back to, instead of claiming a failed PATCH is never worded from the API's text. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Harshi Shah <harshi.shah@contentstack.com> Co-authored-by: Sakshi Koli <sakshi.koli@contentstack.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
Harshi-Shah-CS
changed the title
SakshiKoli-CS
approved these changes
Oct 22, 2026
Reetika-Chavan
approved these changes
Oct 22, 2026
AryanBansal-launch
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the routine review of #245, #246 and #247. Three fixes; the other findings were checked and left alone.
variable.parsenow splits aKEY=value/KEY: valueline at whichever of=and:comes first, soURL=http://xandA:b=ckeep the value intact.allPagesin the CMA client used to stop silently after 100 pages and return a partial list. It now raisesCmaScanLimitError(aUsageError) naming what it was listing (stacks/delivery tokens).ENVIRONMENT_ERROR_MESSAGESentry falls back to the API's own message, and describesCmaScanLimitError.Tests
Scoped tests, eslint and the full coverage run all pass: 138 suites, 2,379 tests, 100% statements / branches / functions / lines.
.talismanrcchecksums are refreshed for the five touched files.#claude_code#
🤖 Generated with Claude Code