Skip to content

Fix recalc_abilities script #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oaphi wants to merge 3 commits into
base: develop
Choose a base branch
from
+14 −1
Open

Fix recalc_abilities script #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b9a088
Fix typo in recalc_abilities script
Oaphi Aug 10, 2026
685e83f
Add test to catch recalc_abilities script breaking
Oaphi Aug 10, 2026
3d6fd01
Add scripts as a checked component to codecov
Oaphi Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/.codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ component_management:
name: tasks
paths:
- app/tasks/**
- component_id: module_scripts
name: scripts
paths:
- app/scripts/**
2 changes: 1 addition & 1 deletion scripts/recalc_abilities.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
end
end.parse!

RecalcAbilitiesJob.perform_now(options)
RecalcAbilitiesJob.perform_now(**options)
9 changes: 9 additions & 0 deletions test/scripts/recalc_abilities_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
require 'test_helper'

class RecalcAbilitiesTest < ActiveSupport::TestCase
test 'should correctly run the script' do
assert_nothing_raised do
system('bundle exec rails runner scripts/recalc_abilities.rb', exception: true)
end
end
end
Loading