Skip to content

Fix recalc_abilities script - #2133

Open
Oaphi wants to merge 3 commits into
developfrom
0valt/script-hotfix
Open

Fix recalc_abilities script#2133
Oaphi wants to merge 3 commits into
developfrom
0valt/script-hotfix

Conversation

@Oaphi

@Oaphi Oaphi commented Aug 10, 2026

Copy link
Copy Markdown
Member

Say hi to our first (rather basic, but still) test for scripts as well!

@Oaphi
Oaphi requested a review from ArtOfCode- August 10, 2026 19:37
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.02%. Comparing base (f4811c5) to head (3d6fd01).

Additional details and impacted files
Components Coverage Δ
controllers 76.84% <ø> (ø)
helpers 85.47% <ø> (ø)
jobs 77.43% <ø> (ø)
models 93.23% <ø> (ø)
tasks 61.11% <ø> (ø)
scripts ∅ <ø> (∅)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi
Oaphi requested review from cellio and trichoplax August 10, 2026 20:38
cellio

This comment was marked as resolved.

@cellio

cellio commented Aug 10, 2026

Copy link
Copy Markdown
Member

I'm still having a problem where the script doesn't actually seem to recalculate abilities, though hitting the "recalc abilities" button for a user directly in the mod tools does work. I'm guessing there's some difference in the paths taken to the "actually do it" code from the button vs from the script, and therein lurks a problem.

Retracted. The script runs based on a queue and the mod tool doesn't count as a queuable event. When I did something to actually force something into the queue, the script worked as expected. (Filed #2134 for the queue/tool mismatch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants