Repository navigation
feat: add ErrorHandler to AcceptOptions #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mafredri
wants to merge
18
commits into
master
Choose a base branch
from
mafredri/accept-error-handler
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+311
−7
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4943af2
test(accept): pin Accept rejection responses
mafredri 6fd030c
feat: add AcceptOptions.ErrorHandler
mafredri 03b8464
refactor(accept.go): rename writeRejection body to defaultBody
mafredri 0da28b3
docs(accept.go): state that ErrorHandler err is not for the client
mafredri abec5f7
test(accept_test.go): check ErrorHandler is not called on hijack failure
mafredri b89a28e
test(accept_test.go): send the server subtest request over a raw conn
mafredri d0934c6
test(accept_test.go): check ErrorHandler receives the Accept request
mafredri b17bcf7
test(accept_test.go): derive default responses from the rejection rows
mafredri ea69999
test(accept_test.go): cover the Origin parse and no-host rejections
mafredri c308410
docs(accept.go): say only that ErrorHandler err may hold server details
mafredri 3639a4c
test(accept_test.go): restore why the server subtest uses a real server
mafredri cfe27d4
fix(accept): pass the OriginPatterns parse error to ErrorHandler
mafredri 4eadda6
docs(accept.go): drop the ErrorHandler clause the doc already states
mafredri 0b8828a
fix: name OriginPatterns in the invalid pattern error
mafredri d0c6748
test(accept_test.go): fix the badOriginPattern comment
mafredri 22d033f
docs: fix comment sentences that start lowercase or give code intent
mafredri bc50b08
docs(accept.go): rewrite the ErrorHandler doc
mafredri 911a8c8
docs(accept.go): shorten the Accept error response sentence
mafredri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.