Skip to content
Navigation Menu
Sign in
Products
Platform
GitHub
Repository hosting, code review, and collaboration
Copilot
AI coding agent for tasks, projects, and automated work
Build & Ship
Actions
CI/CD and automation
Code Quality
Quality analysis, fixes, and enforcement
Codespaces
Cloud development environments
Secure
Code Security
Vulnerability detection and remediation
Secret Protection
Secret scanning and leak prevention
All Features
Developers
Learn
Documentation
Training
Certifications
Build
Build with Copilot
Customize Copilot
Integrations
Explore
Trending repos
GitHub Sponsors
Developer articles
Changelog
Changelog
Your source for the latest features, improvements, and fixes across GitHub products, all in one place.
Businesses
By Stage
Enterprises
Team
Startups
Nonprofits
By Industry
Healthcare
Financial services
Manufacturing
Government
See all industries
Evaluate GitHub
Why GitHub
Customer Stories
Business insights
Trust Center
Add-ons
GitHub Advanced Security
Enterprise-grade code security
Copilot for business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Resources
Learn & Connect
Documentation
Resource center
Blog
Events & webinars
Community Forum
Customer Stories
Integrations
Support
Customer support
Training
GitHub Status
Company
About
Partners
Changelog
GitHub Universe
GitHub Universe
The event for developers, by developers — talks, workshops, and what’s next for GitHub.
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
coder
websocket
Repository navigation
Code
Issues
59
(59)
Pull requests
25
(25)
Actions
Security and quality
Insights
More
items
feat: add ErrorHandler to AcceptOptions
- #588
#588
Draft
mafredri
wants to merge 18 commits into
master
coder/websocket:master
from
mafredri/accept-error-handler
coder/websocket:mafredri/accept-error-handler
Copy head branch name to clipboard
Conversation
Commits
18
(18)
Checks
Files changed
Draft
feat: add ErrorHandler to AcceptOptions
#588
mafredri
wants to merge 18 commits into
master
coder/websocket:master
from
mafredri/accept-error-handler
coder/websocket:mafredri/accept-error-handler
Copy head branch name to clipboard
Commits
Commits on Nov 18, 2026
test(accept): pin Accept rejection responses
Show description for 4943af2
mafredri
committed
4943af2
View commit details
Copy full SHA for 4943af2
Browse repository at this point
feat: add AcceptOptions.ErrorHandler
Show description for 6fd030c
mafredri
committed
6fd030c
View commit details
Copy full SHA for 6fd030c
Browse repository at this point
refactor(accept.go): rename writeRejection body to defaultBody
Show description for 03b8464
mafredri
committed
03b8464
View commit details
Copy full SHA for 03b8464
Browse repository at this point
docs(accept.go): state that ErrorHandler err is not for the client
Show description for 0da28b3
mafredri
committed
0da28b3
View commit details
Copy full SHA for 0da28b3
Browse repository at this point
test(accept_test.go): check ErrorHandler is not called on hijack failure
Show description for abec5f7
mafredri
committed
abec5f7
View commit details
Copy full SHA for abec5f7
Browse repository at this point
test(accept_test.go): send the server subtest request over a raw conn
Show description for b89a28e
mafredri
committed
b89a28e
View commit details
Copy full SHA for b89a28e
Browse repository at this point
test(accept_test.go): check ErrorHandler receives the Accept request
Show description for d0934c6
mafredri
committed
d0934c6
View commit details
Copy full SHA for d0934c6
Browse repository at this point
test(accept_test.go): derive default responses from the rejection rows
Show description for b17bcf7
mafredri
committed
b17bcf7
View commit details
Copy full SHA for b17bcf7
Browse repository at this point
test(accept_test.go): cover the Origin parse and no-host rejections
Show description for ea69999
mafredri
committed
ea69999
View commit details
Copy full SHA for ea69999
Browse repository at this point
docs(accept.go): say only that ErrorHandler err may hold server details
Show description for c308410
mafredri
committed
c308410
View commit details
Copy full SHA for c308410
Browse repository at this point
test(accept_test.go): restore why the server subtest uses a real server
Show description for 3639a4c
mafredri
committed
3639a4c
View commit details
Copy full SHA for 3639a4c
Browse repository at this point
fix(accept): pass the OriginPatterns parse error to ErrorHandler
Show description for cfe27d4
mafredri
committed
cfe27d4
View commit details
Copy full SHA for cfe27d4
Browse repository at this point
docs(accept.go): drop the ErrorHandler clause the doc already states
Show description for 4eadda6
mafredri
committed
4eadda6
View commit details
Copy full SHA for 4eadda6
Browse repository at this point
fix: name OriginPatterns in the invalid pattern error
Show description for 0b8828a
mafredri
committed
0b8828a
View commit details
Copy full SHA for 0b8828a
Browse repository at this point
test(accept_test.go): fix the badOriginPattern comment
Show description for d0c6748
mafredri
committed
d0c6748
View commit details
Copy full SHA for d0c6748
Browse repository at this point
docs: fix comment sentences that start lowercase or give code intent
Show description for 22d033f
mafredri
committed
22d033f
View commit details
Copy full SHA for 22d033f
Browse repository at this point
docs(accept.go): rewrite the ErrorHandler doc
Show description for bc50b08
mafredri
committed
bc50b08
View commit details
Copy full SHA for bc50b08
Browse repository at this point
docs(accept.go): shorten the Accept error response sentence
Show description for 911a8c8
mafredri
committed
911a8c8
View commit details
Copy full SHA for 911a8c8
Browse repository at this point
You can’t perform that action at this time.