Repository navigation
Conversation
…l hint on CLI - Every language now has all the component's keys (admin, menu and site); CI's language check reports no warnings any more (it had 20). - New: pt-BR and pt-PT (admin, menu, site), listed in the manifest. - The installation hint printed markup and an empty link when installing from the command line (Route::_() is empty there); it is plain text with a relative link now. The new strings are translations by Claude and want a review by native speakers; pt-PT was adapted from pt-BR. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMQH6FykdAThUz1bofn
- DESC_BLOCK_IPADDRESS (ca, es, it, ru) only said "the IP address to block" and left out the subnet (CIDR) notation and the warning. - DESC_ALLOWLIST_NOTES (fr) was a fragment; WARNING_ADMIN_USER_EXISTS (ca) was garbled; IP_PRIVATE_OR_RESERVED (de) lacked the address (%s). - it: removed zero-width spaces in the unblock success message. - pt-PT adapted to European Portuguese. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMQH6FykdAThUz1bofn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The CI "Language files" step passed, but reported 20 non-failing warnings (missing keys). They are all gone now:
php tests/lint/check-language.php bfstop.xml COM_BFSTOPreports 0 errors, 0 warnings..sys.ini) and site.bfstop.xml. The plugin already has them.installscript.php: when installing from the command line (as CI does), the installation hint printed raw<a href="">markup with an empty link, becauseRoute::_()returns an empty string there. On the command line it is now plain text, and the link falls back to the relative settings URL.Goes together with codeling/bfstop (branch of the same name), which has the plugin's strings.
Review needed
The new strings are translations by Claude and should be checked by native speakers. pt-PT was adapted from pt-BR with a word list, so it needs the closest look. Placeholders (
%s,%1$d) and HTML tags were checked against en-GB by a script; the two descriptions with<subnet address>/<mask bits>have that placeholder text translated on purpose../deploy.sh zip+tests/lint/check-zip.php: 34 manifest entries, 0 missing.Generated by Claude Code