Skip to content

Form rules: declare nullable parameters (PHP 8.4 deprecation) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeling merged 1 commit into from
Nov 6, 2026
Merged

Form rules: declare nullable parameters (PHP 8.4 deprecation) #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/rules/date.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

class JFormRuleDate extends FormRule
{
public function test(SimpleXMLElement $element, $value, $group = null, Registry $input = null, Form $form = null)
public function test(SimpleXMLElement $element, $value, $group = null, ?Registry $input = null, ?Form $form = null)
{
if ($value === '' || $value === null)
{
Expand Down
2 changes: 1 addition & 1 deletion admin/rules/emaillist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/
class JFormRuleEmaillist extends FormRule
{
public function test(SimpleXMLElement $element, $value, $group = null, Registry $input = null, Form $form = null)
public function test(SimpleXMLElement $element, $value, $group = null, ?Registry $input = null, ?Form $form = null)
{
$value = trim((string) $value);
if ($value === '')
Expand Down
2 changes: 1 addition & 1 deletion admin/rules/geodbpath.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class JFormRuleGeodbpath extends FormRule
{
public function test(SimpleXMLElement $element, $value, $group = null, Registry $input = null, Form $form = null)
public function test(SimpleXMLElement $element, $value, $group = null, ?Registry $input = null, ?Form $form = null)
{
$value = (string) $value;
if ($value === '')
Expand Down
2 changes: 1 addition & 1 deletion admin/rules/htaccesspath.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class JFormRuleHtaccesspath extends FormRule
{
public function test(SimpleXMLElement $element, $value, $group = null, Registry $input = null, Form $form = null)
public function test(SimpleXMLElement $element, $value, $group = null, ?Registry $input = null, ?Form $form = null)
{
$value = (string) $value;
if ($value === '')
Expand Down
2 changes: 1 addition & 1 deletion admin/rules/iprange.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class JFormRuleIprange extends FormRule
{
public function test(SimpleXMLElement $element, $value, $group = null, Registry $input = null, Form $form = null)
public function test(SimpleXMLElement $element, $value, $group = null, ?Registry $input = null, ?Form $form = null)
{
return IpValidateHelper::validIPRange($value);
}
Expand Down
2 changes: 1 addition & 1 deletion admin/rules/iprangeblock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class JFormRuleIprangeblock extends FormRule
{
public function test(SimpleXMLElement $element, $value, $group = null, Registry $input = null, Form $form = null)
public function test(SimpleXMLElement $element, $value, $group = null, ?Registry $input = null, ?Form $form = null)
{
return (IpValidateHelper::validIPRange($value) && !IpValidateHelper::matchesCurrentIP($value));
}
Expand Down
Loading