Repository navigation
Form rules: declare nullable parameters (PHP 8.4 deprecation) - #28
Merged
Merged
Conversation
PHP 8.4 deprecates parameters with a type which default to null without
being declared nullable ("Implicitly marking parameter $input as nullable
is deprecated"). The six form rules declared Registry $input = null,
Form $form = null; they now have ?Registry and ?Form, as Joomla's own
FormRule::test() has in Joomla 5 and 6. These were the six deprecations
the plugin's tests report on Joomla 6 with PHP 8.4.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AFJFMMUpch4LGexEiXN8Nc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates typed parameters that default to
nullwithout being declared nullable ("Implicitly marking parameter$inputas nullable is deprecated"). The six form rules inadmin/rules/declaredtest(..., Registry $input = null, Form $form = null). They now use?Registryand?Form, which is exactly the signature of Joomla's ownFormRule::test()in Joomla 5 and 6.These are most likely the "Deprecations: 6" the plugin's integration tests report on every Joomla 6 / PHP 8.4 job, on
maintoo. They're the only implicitly nullable parameters in both repositories, and there are six of them. The plugin PR on the branch of the same name (codeling/bfstop#258) makes PHPUnit print deprecation details, so its CI run against this branch shows whether they're gone.Locally:
php -lpasses on all six files. I couldn't run PHP 8.4 here, so the PHP 8.4 jobs in CI are the real check.Generated by Claude Code