Repository navigation
Conversation
- Every language now has all the plugin's keys; CI's language check reports no warnings any more (it had 23). - pt-BR and pt-PT are complete and listed in the manifest, so they are installed (they were in the repository, but not shipped). - pt-BR/pt-PT: PLG_SYSTEM_BFSTOP_ORIGEM renamed to PLG_SYSTEM_BFSTOP_ORIGIN. - es-ES, pt-BR, pt-PT: removed the obsolete PLG_SYSTEM_BFSTOP_LOGGING_ENABLED_*. The new strings are translations by Claude and want a review by native speakers; pt-PT was adapted from pt-BR. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMQH6FykdAThUz1bofn
- PASSWORD_RESET_RECOMMENDED (ca, es, fr, nl): the link had '%1' instead of '%1$s', which makes sprintf() throw a ValueError; texts follow the English one again. - BLOCKED_IP_ADDRESS_BODY (es, pt-BR, pt-PT, ru): was the old text with plain %s and without the notice; now as the English one. Typos fixed in ca, fr, nl. - NOTIFY_BLOCKED_USER_DESC (all but de) and USE_HTTP_ERROR_DESC (all but de): described the behaviour before the unblock link and its error statuses; updated. EMAIL_ADDRESS_DESC (ca, es, it, pt), LOGLEVEL_DESC (fr), MAX_BLOCKS_BEFORE_DESC (nl) were missing half of the text. - FAILED_LOGIN_ATTEMPT (ca, fr, it, ru) had lost its first %s or its meaning; BLOCKED_IP_MESSAGE (pt) printed a stray %s, BLOCKED_SUBJECT (pt) had '% s'; pt-BR BLOCKED_BODY, BLOCKED_MESSAGE_DESC and NOTIFY_REMAINING_ATTEMPTS_DESC reworded. - pt-PT had been a copy of pt-BR (usuário, arquivo, senha, ...); it is now in European Portuguese. - ca: '</ h2>' in the description. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMQH6FykdAThUz1bofn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The CI "Language files" step passed, but reported 23 non-failing warnings (missing keys in translations). They are all gone now:
php tests/lint/check-language.php bfstop.xml PLG_SYSTEM_BFSTOPreports 0 errors, 0 warnings.bfstop.xml. They were in the repository, but not installed with the plugin.PLG_SYSTEM_BFSTOP_ORIGEMrenamed toPLG_SYSTEM_BFSTOP_ORIGIN(the code uses the latter).PLG_SYSTEM_BFSTOP_LOGGING_ENABLED_LABEL/_DESC(not used anywhere).Goes together with codeling/com_bfstop (branch of the same name), which has the same for the component.
Review needed
The new strings are translations by Claude and should be checked by native speakers. pt-PT was adapted from pt-BR with a word list (utilizador, ficheiro, palavra-passe, ...), so it needs the closest look. Placeholders (
%s,%1$d) and HTML tags were checked against en-GB by a script.Not changed
Existing translations which are outdated but have all their keys (e.g. the pt-BR
PLG_SYSTEM_BFSTOP_BLOCKED_IP_MESSAGEstill has a stray%s,BLOCKED_SUBJECThas% s) were left as they are.Generated by Claude Code