Repository navigation
Tell translators where "Playing from" and "Connected for" are shown - #50
Merged
Merged
Conversation
Out of context, "Connected for" was translated as "connected for the benefit of" rather than "for how long". Each string now has a comment saying where it appears, in the code and so in the String Catalog, which Transifex shows translators. "Connected for" is a LabeledContent with a Text label, as only a Text takes a comment; it looks the same. The Android remote's same strings have the same comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J1hktAVUxNdVQ8kB7kcTzB
ScreenshotsFrom run 37531041409, against a real Clementine. Left: main. Right: this pull request, light and dark.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translators see these two strings without the screen around them. "Connected for" was translated into Russian as "Подключено для", which means "connected for the benefit of" rather than "connected for how long".
Each string now has a comment saying where it appears. Transifex shows these comments to translators.
The comments live in the code (
Text(_:comment:)), and from there in the String Catalog. "Connected for" now usesLabeledContentwith aTextlabel, because only aTexttakes a comment; it looks the same as before. I added the comments to the catalog by hand, in the layout Xcode writes, and CI's catalog check confirms that a build would produce the same file.The Android remote's same two strings get the same comments in clementine-player/Android-Remote#349.
No release note: users don't see any change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01J1hktAVUxNdVQ8kB7kcTzB
Generated by Claude Code