Repository navigation
Tell translators where "Playing from" and "Connected for" are shown - #349
Merged
Merged
Conversation
Out of context, "Connected for" was translated as "connected for the benefit of" rather than "for how long". A comment before each string says where it appears, which Transifex shows translators. The iOS remote's same strings have the same comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J1hktAVUxNdVQ8kB7kcTzB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translators see these two strings without the screen around them. In the iOS remote, "Connected for" was translated into Russian as "Подключено для", which means "connected for the benefit of" rather than "connected for how long". Android has the same two strings.
Each string now has an XML comment just before it, saying where it appears. Transifex shows these comments to translators as developer notes.
connection_uptime: "Label for how long the phone has been connected to Clementine, shown next to it as a duration such as 01:23:45."player_playing_from: "Small heading at the top of the player, above the name of the playlist the song is playing from."The iOS remote's same strings get the same comments in clementine-player/iOS-Remote#50.
No release note: users don't see any change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01J1hktAVUxNdVQ8kB7kcTzB
Generated by Claude Code