Repository navigation
Name Clementine's computer as Clementine does - #325
Merged
Merged
Conversation
The output sheet called Clementine's own output "This computer", which reads as the phone. Clementine now sends its computer's host name, so the sheet shows that, or "Clementine" when it doesn't say. Release-note: "Play on" names Clementine's computer instead of saying "This computer". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CTf1Z6GAbDbQeNJ5BkewC1
…connection sheet The connection chip and the connection sheet's heading showed the name the network gave Clementine's address, or the address itself, which needn't match the name "Play on" shows. They now show the name Clementine sends, when it sends one. Release-note: The top of the screen and the connection details name Clementine's computer as Clementine does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CTf1Z6GAbDbQeNJ5BkewC1
hatstand
enabled auto-merge (rebase)
October 5, 2026 16:29
Store screenshotsFrom run 37340822106, against clementine-it. Left: the store listing of the latest release, v13.7, which shows the dark theme. Right: this pull request, dark and light.
|
Contributor
Author
|
I've re-run the failed job once. Generated by Claude Code |
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Play on" called Clementine's own output "This computer", which reads as the phone. Clementine now sends its computer's host name (or a
--remote-nameoverride), in clementine-player/Clementine#7586.Same change on iOS: clementine-player/iOS-Remote, branch
claude/nifty-ramanujan-c2i3zy.A Clementine from before clementine-player/Clementine#7586 still sends "This computer", and that's what shows until it's updated.
Tests:
OutputSheetTest(name and fallback) andRemoteRepositoryTest(computerName). Not built here: the session had no Android SDK, so CI is the first build.The "(this tablet)" wording is a separate PR from
claude/android-tablet-output-label; the two touch the same lines ofOutputSheet.kt, so whichever merges second needs a small conflict resolved.🤖 Generated with Claude Code
https://claude.ai/code/session_01CTf1Z6GAbDbQeNJ5BkewC1
Generated by Claude Code