Skip to content

Call a tablet a tablet in "Play on" - #326

Merged
hatstand merged 1 commit into
masterfrom
claude/android-tablet-output-label
Oct 5, 2026
Merged

hatstand merged 1 commit into
masterfrom
claude/android-tablet-output-label

Conversation

@hatstand

@hatstand hatstand commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Playing on this device, "Play on" said "(this phone)" and showed a phone icon even on a tablet. On a tablet (smallest width at least 600dp) it now says "(this tablet)" with a tablet icon, as iOS already says "(this iPad)". The icon changes on the output button and the player's "Playing on" line too.

Android only: iOS already does this.

Test: OutputSheetTest.aTabletIsCalledATablet, run at sw600dp. Not built here: the session had no Android SDK, so CI is the first build.

This touches the same lines of OutputSheet.kt as the PR from claude/nifty-ramanujan-c2i3zy, so whichever merges second needs a small conflict resolved.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CTf1Z6GAbDbQeNJ5BkewC1


Generated by Claude Code

@hatstand
hatstand enabled auto-merge (rebase) October 5, 2026 16:30
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Store screenshots

From run 37350146299, against clementine-it. Left: the store listing of the latest release, v13.7, which shows the dark theme. Right: this pull request, dark and light.

Screen v13.7 This PR, dark This PR
1_player
2_library
2_library_album
3_playlist
4_search
5_connection
6_connect
10_internet –
11_internet_radio –
settings –

hatstand commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

integration failed in ClementineIntegrationTest.globalSearchFindsLibrarySongs, but not because of this PR. The library results came back. The test then waits up to 15 s for GlobalSearchFinished, which Clementine only sends once every internet radio search provider has answered, and those query live services. In this run SomaFM's request failed (SSL handshake failed: The issuer certificate of a locally looked up certificate could not be found), and the search hadn't finished in time.

This PR only changes the "Play on" label and icon, which this test never touches, and the same test passed on #325 and #327 in the same hour.

I've re-run the failed job once. If it fails the same way again, I'll treat it as a real problem with the test's dependence on outside services (not something to fix in this PR) and say so here.


Generated by Claude Code

Playing on this device, the output sheet said "(this phone)" and showed a
phone even on a tablet. On a tablet it now says "(this tablet)", with a
tablet icon, as iOS says "(this iPad)".

Release-note: On a tablet, "Play on" calls it this tablet rather than this phone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CTf1Z6GAbDbQeNJ5BkewC1
@hatstand
hatstand force-pushed the claude/android-tablet-output-label branch from 66f01d1 to 548a1f3 Compare October 5, 2026 17:40
@hatstand
hatstand merged commit 5cfed5d into master Oct 5, 2026
7 checks passed
@hatstand
hatstand deleted the claude/android-tablet-output-label branch October 5, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants