Skip to content

fix: move MCP SDK requires to top level so pkg can bundle them #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhoffer-arch merged 3 commits into from
Apr 13, 2026
Merged

fix: move MCP SDK requires to top level so pkg can bundle them #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9e9962
fix: correct Claude Desktop auto-config for both pkg and node modes
claude Apr 13, 2026
fbb5302
fix: use node + script path instead of unpublished npx package
claude Apr 13, 2026
5169083
fix: move MCP SDK requires to top level so pkg can bundle them
claude Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,14 @@
"zod": "^3.25.0"
},
"pkg": {
"scripts": [
"node_modules/@modelcontextprotocol/sdk/**/*.js",
"node_modules/zod/**/*.js"
],
"assets": [
"node_modules/@modelcontextprotocol/sdk/**/*",
"node_modules/zod/**/*"
"node_modules/@modelcontextprotocol/sdk/**/*.json",
"node_modules/zod/**/*.json",
"tools.js"
]
},
"license": "MIT"
Expand Down
29 changes: 18 additions & 11 deletions smart-bridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ const fs = require('fs');
const os = require('os');
const path = require('path');
const { spawn } = require('child_process');
const { McpServer } = require('@modelcontextprotocol/sdk/server/mcp.js');
const { StdioServerTransport } = require('@modelcontextprotocol/sdk/server/stdio.js');
const { z } = require('zod');

const VERSION = require('./package.json').version;
const WS_PORT = 19802;
Expand Down Expand Up @@ -87,7 +90,18 @@ function getClaudeConfigPath() {

function configureClaude() {
const configPath = getClaudeConfigPath();
const binaryPath = process.pkg ? getInstallPath() : process.execPath;

// Determine the right command + args for Claude Desktop to spawn us
let command, args;
if (process.pkg) {
// Running as compiled binary — use the installed binary path directly
command = getInstallPath();
args = ['--mcp'];
} else {
// Running via node — use node + absolute path to this script
command = process.execPath;
args = [path.resolve(__dirname, 'smart-bridge.js'), '--mcp'];
}

let config = {};
try {
Expand All @@ -98,17 +112,14 @@ function configureClaude() {

if (!config.mcpServers) config.mcpServers = {};

// Already configured — check if path still matches
// Already configured with the same command — skip
if (config.mcpServers.clashcontrol) {
const existing = config.mcpServers.clashcontrol;
if (existing.command === binaryPath) return; // already correct
if (existing.command === command) return;
}

// Add or update the clashcontrol entry
config.mcpServers.clashcontrol = {
command: binaryPath,
args: ['--mcp']
};
config.mcpServers.clashcontrol = { command, args };

try {
fs.mkdirSync(path.dirname(configPath), { recursive: true });
Expand Down Expand Up @@ -419,10 +430,6 @@ function startRestServer() {
// ── MCP Server (Claude Desktop) ──────────────────────────────────

async function startMcpServer() {
const { McpServer } = require('@modelcontextprotocol/sdk/server/mcp.js');
const { StdioServerTransport } = require('@modelcontextprotocol/sdk/server/stdio.js');
const { z } = require('zod');

const mcp = new McpServer({ name: 'ClashControl', version: VERSION }, { instructions: MCP_INSTRUCTIONS });

registerMcpTools(mcp, z, sendToBrowser);
Expand Down
Loading