fix: move MCP SDK requires to top level so pkg can bundle them - #13
Merged
Conversation
- pkg binary: uses the installed binary path as command - node/dev mode: uses npx -y @clashcontrol/mcp-server - Previously used process.execPath which pointed to node binary itself, resulting in a broken config entry https://claude.ai/code/session_01XEvUykWcLc452uxGWPb1mb
The npm package @clashcontrol/mcp-server isn't published yet. When running via node (non-pkg), use process.execPath + absolute path to smart-bridge.js instead of npx. https://claude.ai/code/session_01XEvUykWcLc452uxGWPb1mb
The compiled binary crashed with "Cannot find module '@modelcontextprotocol/sdk/server/mcp.js'" because pkg can't trace require() calls inside conditional function bodies. Fix: move requires to top-level imports. Also change pkg config from assets to scripts for .js files so they're properly compiled into the binary, and add tools.js to assets. https://claude.ai/code/session_01XEvUykWcLc452uxGWPb1mb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.