Skip to content

Restore net45 compatibility in ResizingUtil.AppendQuery to unblock Windows CI build #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsword merged 2 commits into from
Sep 27, 2026
Merged

Restore net45 compatibility in ResizingUtil.AppendQuery to unblock Windows CI build #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7526f4e
Merge pull request #15 from chsword/codex/fix-274085-41134369-7985095…
chsword Sep 27, 2026
4208b50
Fix net45-incompatible query separator check
Copilot Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/ResizingClient/ResizingUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
{
stream.Seek(0, SeekOrigin.Begin);
var bytes = new byte[stream.Length];
stream.Read(bytes, 0, (int)stream.Length);

Check warning on line 78 in source/ResizingClient/ResizingUtil.cs

View workflow job for this annotation

GitHub Actions / build (10.0.x, net10.0) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 78 in source/ResizingClient/ResizingUtil.cs

View workflow job for this annotation

GitHub Actions / build (10.0.x, net10.0) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
return Upload(bytes, filename, category);
}

Expand Down Expand Up @@ -105,7 +105,7 @@
var fragmentIndex = url.IndexOf('#');
var fragment = fragmentIndex >= 0 ? url.Substring(fragmentIndex) : string.Empty;
var urlWithoutFragment = fragmentIndex >= 0 ? url.Substring(0, fragmentIndex) : url;
var separator = urlWithoutFragment.IndexOf('?', StringComparison.Ordinal) >= 0 ? "&" : "?";
var separator = urlWithoutFragment.IndexOf('?') >= 0 ? "&" : "?";
return $"{urlWithoutFragment}{separator}{query}{fragment}";
}

Expand Down
Loading