Repository navigation
Restore net45 compatibility in ResizingUtil.AppendQuery to unblock Windows CI build - #16
Merged
Merged
Conversation
chsword
added this pull request to stack #17
September 27, 2026 05:29
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job
Restore net45 compatibility in Sep 27, 2026
ResizingUtil.AppendQuery to unblock Windows CI build
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The compatibility fix is minimal and preserves existing behavior.
Review effort: Lite
Findings: None
What changed in this PR
Restores net45 compatibility in ResizingUtil.AppendQuery without changing URL behavior.
Changes:
- Replaces the unsupported
IndexOfoverload. - Preserves query-separator handling.
| File | Summary |
|---|---|
source/ResizingClient/ResizingUtil.cs |
Updates AppendQuery for net45 compatibility. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chsword
marked this pull request as ready for review
September 27, 2026 06:03
Base automatically changed from
codex/fix-274085-41134369-79850956-2304-4181-a26f-944951529bcd
to
master
September 27, 2026 06:05
…6-2304-4181-a26f-944951529bcd Add .NET 10 multi-targeting and CDN-style URL formatting compatibility
Co-authored-by: chsword <274085+chsword@users.noreply.github.com>
chsword
force-pushed
the
copilot/fix-github-actions-job
branch
from
September 27, 2026 06:05
282b649 to
4208b50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing GitHub Actions Windows build was caused by a
net45compile error inResizingClient:string.IndexOf(char, StringComparison)is not available for that target. This PR applies a minimal compatibility fix in the URL query-separator path.Root cause
AppendQueryused a newerIndexOfoverload incompatible withnet45, breakingResizingClientcompilation in the CI job.Change made
net45-safe check while preserving behavior (detect existing?and choose&vs?).Scope
source/ResizingClient/ResizingUtil.cs.