Conversation
…pe [RED-991] Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The interactive
checkly deploywrite-back (#1494, #1495) listed a change toruntimeId, or to the request of a TCP, DNS, ICMP, gRPC, SSL or traceroute monitor, asnot a property this tool can update. These are plain literals in the construct, and the deploy plan reports all but the SSL request under the construct's own key names, so they now get rule-table entries:ApiCheck,BrowserCheck,MultiStepCheck,PlaywrightCheck, check groupsruntimeId(the classes that take one; a monitor's or agentic check's/runtimeIdchange keeps the generic reason)TcpMonitorrequest.hostname,port,data,ipFamilyDnsMonitorrequest.recordType,query,protocol;nameServerandportwritten together, as the construct refuses one without the otherIcmpMonitorrequest.hostname,ipFamily,pingCountGrpcMonitorrequest.url,port,ipFamily,skipSSL,timeoutand thegrpcConfigkeys (metadatahas a rule only so its refusal names the real reason: the account blanks every value)SslMonitor/request/sslConfig/{hostname,port,ipFamily}→request.*,handshakeTimeoutMs→sslConfig.handshakeTimeout,/request/sslClientCertificateId→sslConfig.sslClientCertificateId, the rest undersslConfigTracerouteMonitorThe key lists are typed against the construct request interfaces (
satisfies readonly (keyof TcpRequest)[]), so a renamed property fails the build.One planner change: the deployed state the plan carries is the import format, which leaves out an optional key the account cleared (
serverName,nameServer,data, …) while the change reports it asnull. At the rule's own leaf that absence now agrees, and the property is refused withCheckly has no value for <property>; edit the property by handinstead ofCheckly reported two different current values. Below the leaf the disagreement stands, since the parent would otherwise be written without the key.Testing
plan.spec.ts: every monitor's request written (incl. the SSL mapping and a rolled-upsecurityBaseline), the refusals (gRPCencoding, gRPC metadata as a secret and as a blanked value, a cleared optional key, the DNS pair when one member is a variable),runtimeIdreplaced, inserted, cleared and refused on a monitor, and a coverage test that every key of each monitor's request has a rule. 34 tests pass; lint andtscclean.Stacked on #1495 (RED-986). Docs: checkly/docs#519, to merge with the CLI release.
🤖 Generated with Claude Code