Conversation
… one [RED-992] Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…d time [RED-992] Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The write-back rule table (
services/write-back/plan.ts) was a hand-written list per construct class: a prop added to a construct silently got the genericnot a property this tool can updatereason. #1496 guarded the request interfaces at compile time; this extends the guard to every props type behind the table.as constlists typed withsatisfies readonly (keyof XProps)[], and the identity rules are built from them.CheckProps,RuntimeCheckProps,MonitorProps, the props of all 13 check and monitor classes, both groups,ApiCheckDefaultConfig) to its class's written list in both directions: every key is written or named in one of the reasoned allow-lists (ReferenceKey,ContentKey,BundleKey,LocalOnlyKey,NotWrittenKey,GroupMemberKey,NotYetKey), and every written key exists on the props. Adding a prop to a construct now failstscuntil the rewriter writes it or names why it does not.WRITTEN_BY_CLASSexports the same lists so a spec holdsRULES_BY_CLASSto them (per class, the non-companion top-level targets equal the written list).Building the lists surfaced three props that are plain literals the account reports under the construct's own name, which now get rules:
sslCheckDomainandaiAutoRepairEnabledonBrowserCheck,aiAutoRepairEnabledonMultiStepCheck,promptonAgenticCheck.triggerIncidentgets its own reason (Checkly does not report the incident trigger's settings; edit it by hand), since the deployed state the plan carries holds only the flag while the change reports the trigger's settings.Writing
promptneeded one renderer change: a multi-line string replacing a template literal is written as a template literal (backslash, backtick and${escaped) instead of a one-line quoted string, so a prompt or description keeps the author's form. A value holding a control character other than LF or TAB falls back to the quoted form, because a template normalises CR and CRLF to LF and the file would not read back as the same value.Left out on purpose
playwrightConfig(the account nulls its credential sections through object-kind redactions, and a check usually inherits it from the project config, which an insert would pin),engine(one object sent as two leaves) andagentRuntime(holds a set) are named as not written yet and tracked as a gap.Testing
plan.spec.ts: per-class equality of the rule table with the written lists; the new literal props written,playwrightConfigandtriggerIncidentrefused with their reasons; a multi-line prompt rewritten as an escaped template literal, a single-line one quoted, a CRLF one quoted.literal-edit.spec.ts: the template-literal escaping and refusal. 87 write-back tests and the full suite pass; lint andtscclean.Stacked on #1496 (RED-991). Docs: checkly/docs#520, to merge with the CLI release.
🤖 Generated with Claude Code