fix(ci): give the Website Vercel build its growth form policy - #981
Merged
Conversation
The deploy job's `npx vercel build` fails on main:
Error: GROWTH_FORM_POLICY must be growth_v1
Error: Command "npx nx build website" exited with 1
so the Website preview is never built, every later step skips, and production
has not promoted since the control-plane arc landed.
#968 added the assertion in apps/website/src/lib/growth/form-policy.ts and set
GROWTH_FORM_POLICY for the `website` job, but not for the deploy job's build.
It cannot come from `vercel pull`: the project marks GROWTH_FORM_POLICY
sensitive for preview and production, and Vercel never returns a sensitive
value, so the pulled .env omits it. A Vercel-side cloud build would have it;
our prebuilt-on-runner build does not.
Set it on the build step, mirroring the `website` job. It is not a secret, and
runtime is unaffected — Vercel still injects the sensitive value into the
deployed function.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deploy job's
npx vercel buildfails onmain:The Website preview is therefore never built, every later step skips — embedding-policy verification, Website promotion, the cockpit redirect build, cockpit promotion — and production has not promoted since the control-plane arc landed.
Root cause
#968 added the assertion in
apps/website/src/lib/growth/form-policy.ts:35and setGROWTH_FORM_POLICYfor thewebsitejob, but not for the deploy job's build.It cannot come from
vercel pull. The project marksGROWTH_FORM_POLICYsensitive for preview and production:Vercel never returns a sensitive value, so the pulled
.envomits it and the runner-sidevercel buildthrows. A Vercel-side cloud build would have it; our--prebuiltflow does not. That is why #968's own CI was green — thewebsitejob hardcodes the value.Fix
Set it on the build step, mirroring the
websitejob. It is not a secret (the existing comment in that job says so), and runtime is unaffected — Vercel still injects the sensitive value into the deployed function.Verification
form-policy.ts:35.GROWTH_FORM_POLICYis confirmedtype=sensitivewith an empty readback via the Vercel API.websitejob, which sets the same value, builds green every run.ci-workflow.spec.mjs: 36/36.🤖 Generated with Claude Code