ci: PR-side deploy verification against real Vercel previews - #992
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…bypass cookie Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…tifact dirs Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e, SameSite=None, loopback tests Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…iews Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… origin Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… throwaway preview Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…examples preview Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…equest a SameSite=None bypass cookie Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ligible to run Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…cookie header off the runtime origin; cover the 307 bypass answer Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… samesitenone, cockpit cleanup Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Landing #963 took nine fix PRs (#967, #970, #973, #974, #981, #982, #983, #984, #987), every one repairing a step only the push-only deploy job executes. Spec:
docs/superpowers/specs/2026-09-03-pr-side-deploy-verification-design.md. Plan:docs/superpowers/plans/2026-09-03-pr-side-deploy-verification.md.What
website-preview-e2e): assembles the examples with a deterministic Website alias in their parent-origin policy, deploys them as an examples preview underthreadplane-examples-pr-<n>-cacheplane.vercel.app, builds and deploys the Website as a preview pointed at that alias underthreadplane-pr-<n>-cacheplane.vercel.app, and runs the ordinary suite against it. A Playwright global setup (apps/website/e2e/runtime-bypass-setup.ts) seeds the examples origin's bypass cookie as storage state so the runtime iframe reaches Ready on a protected preview.cockpit-preview-smoke): deploys a throwaway cockpit preview, runs the 399-probe smoke against it, and removes it.CI — requiredthroughrequire_preview, which applies the scoped rule only when the lanes were eligible to run (same-repo PR or merge-queue candidate), so fork PRs stay green while the lanes skip.set -euo pipefailplus URL validation on every preview deploy, no--skip-domainon preview deploys (Vercel requires it to accompany--prod), secret redaction in setup errors,SameSite=Noneon the seeded cookie.Provisioning
VERCEL_EXAMPLES_AUTOMATION_BYPASS_SECRETwas generated on the threadplane-examples project and stored before this PR was opened. Because this PR editsci.yml, every scope is on and both lanes run here.Verification
runtime-bypass-setup.spec.ts9/9 (loopback server cases for cookie capture, SameSite normalization, redaction),playwright-config.spec.ts10/10,ci-workflow.spec.mjs41/41.vercel buildenv precedence.🤖 Generated with Claude Code