Repository navigation
BUZZ-518: Explain required community sign-in - #2710
Merged
Merged
Conversation
Co-authored-by: Honor <e0bf479eeebe47dde1e35705212a4df70616a7bc834d907ddfb18cf0405f8b1b@seiler-test.communities.public.builderlabstaging.xyz> Signed-off-by: Brad Seiler <seiler@squareup.com>
Co-authored-by: Honor <e0bf479eeebe47dde1e35705212a4df70616a7bc834d907ddfb18cf0405f8b1b@seiler-test.communities.public.builderlabstaging.xyz> Signed-off-by: Brad Seiler <seiler@squareup.com>
bradseiler
marked this pull request as ready for review
November 6, 2026 00:46
wpfleger96
approved these changes
Nov 6, 2026
wpfleger96
left a comment
wpfleger96
left a comment
Member
There was a problem hiding this comment.
🤖 Reviewed the diff and the component at head. state.authority is null-checked before serverName runs, so the new line and button label can't throw. CommunitySignIn has two callers, the sidebar and the join dialog, and both have updated tests. I found no other test or browser journey that still expects the bare "Sign in" label from this component; the remaining "Sign in" assertions belong to Settings and agent components. No organization-specific values are in source: builderlab.example appears only in test fixtures.
Nonblocking: the description still says "Keep this PR in draft", but the PR is now ready for review.
nathan-thillairajah
added a commit
that referenced
this pull request
Nov 6, 2026
…able-page * origin/main: feat(browser): show a refused Builderlab app as a page in the panel (#2680) fix(profiles): cache profiles on disk and keep dm partners through eviction (#2178) feat(profiles): let each reader show verified people by username or full name (#2356) fix(media): show transparent avatars without a black background (#2477) fix(channels): keep the reader's place when Back returns to a link-opened channel (#2500) BUZZ-518: Explain required community sign-in (#2710) feat(desktop): serve credentials to agents and your CLI, with pairing (#2260) test(solo): wait for search and access before Share focus reveal (#2573) fix(relay): answer bytes a failed spool wrote; deflake the memory read (#1970) ci(release): publish a signed Intel macOS DMG (#1825) Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com> # Conflicts: # docs/browser.md # src-tauri/src/browser/builderlab.rs # src/features/browser/BrowserHostView.test.tsx # src/features/browser/BrowserHostView.tsx # src/features/browser/platform.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a community requires organization sign-in, Buzz shows a bare Sign in button. People cannot tell why they need it or which server to use.
What
Explain “This community requires {serverName} sign-in.” and label the action “Sign in with {serverName}”. The existing shared prompt covers the sidebar and join dialog.
How
Reuse CommunitySignIn, serverName, and the shared Button. Keep cancel, refusal recovery, account switching, and reconnect behavior unchanged. Update existing component, sidebar, and join-dialog tests plus the help guide.
Risk
Copy only; six added production lines. No native, protocol, or LiveStatus changes.
Testing
Rendered the existing identity fixture in Chromium at 1440×950 and 390×844 in light/dark themes, including 150% text. Exercised pointer sign-in/cancel and keyboard Tab/Enter. Also rendered the real CommunityDialog with disposable fixture state: refusal → provider-specific sign-in → cancel → completed sign-in → Continue reaches access requirements. No live credentials or relay used.
Human acceptance, native/live login, and full-app sidebar visual validation remain deferred.
Bigger picture
Supersedes closed #2245 with the smaller BUZZ-518 scope.
Generated with Codex