Repository navigation
Conversation
|
Windows run of the manual acceptance from the description, against a real enforcing NIP-FI deployment (Block's), in case it helps with the "Windows native execution" item. Environment: Windows 11 Enterprise 10.0.26300, WebView2 156, existing Buzz identity, relay in NIP-FI enforce mode (plain WebSocket upgrade → 401). Builds made with the repo-pinned Rust 1.98.1 / pnpm 11.8.0, 1. The branch as-is needs a rebase. Built from 2. Rebased onto
Observations (not blockers):
Build note for Windows without admin: |
04df5c0 to
b130944
Compare
|
@corydouthat-sq Thanks for testing this and documenting the Windows results. I verified the lifetime check you identified and rebased onto upstream That also brings in the macOS Keychain bundling change. There were two conflicts against this newer base: the configuration docs and the session-store constructor. Both are resolved, preserving upstream's launch guidance and Checks on the rebased Mac checkout passed: 113 federation tests, 207 relay tests (2 existing ignored), the native import fixture, formatting, and the mandatory workspace Clippy check. Another 313 existing first-run/sign-in tests passed. Independent Claude Opus 5.5 review found no blockers. The description now credits your Windows acceptance against the build you tested, separately from our checks on this newer head. We're keeping the PR draft pending packaged Mac/real-Keychain/browser SSO testing, human acceptance and hosted CI. Headless Chromium/WebKit also confirmed the separate first-run limitation: an external community still offers Builderlab signup or an existing key. This rebase doesn't expand into that signup work. |
joahg
left a comment
There was a problem hiding this comment.
🤖 Read runtime.rs and the FederatedIdentity::open wiring. Compiled config short-circuits before the file is opened, and the Unix loader opens with O_NOFOLLOW, checks the handle's owner and mode, and bounds the read. The PR itself notes that maintainer agreement on this opt-in local trust model is needed; that decision is outside what I reviewed. Branch currently conflicts with main.
b130944 to
523fc46
Compare
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Nick <ci@kuhn-labs.com>
523fc46 to
2eba153
Compare
|
Rebased onto current main The important scope change upstream is the built-in The current CI run requires approval. I also reproduced an unrelated typecheck failure on clean main: the |
|
The current-head Mac live cycle is now complete on
This used the existing Keychain identity and an enforcing relay in an Apple silicon macOS VM. The validation section retains the packaging limit: this unsigned debug bundle required direct executable launch; Finder launch and signed distribution are not qualified. The zero-compiled-server scope and standard official-download limitation are unchanged. Upstream also fixed the unrelated build fixture in #2783. No additional code was pushed for this test. |
Desktop deployments using a separate NIP-FA/NIP-FI authority currently need to compile their deployment descriptor into Buzz. This adds a local, nonsecret descriptor read at startup for desktops built without any compiled sign-in servers.
The descriptor lives at the existing federation store root as
federated-identity.json; the deployment guide documents each platform's path. A nonempty compiled server registry always wins, without opening the file. Missing local configuration preserves the unconfigured state; malformed, unsafe or unreadable configuration stops startup. Native validation, secure session storage, profile/descriptor fingerprinting and explicit plugin grants remain authoritative. No JavaScript token access or plugin authority setter is added.This intentionally lets a user or deployment operator choose local authority configuration in a previously unconfigured build. A process already able to write as that user can also plant the file and cause a different organization sign-in prompt after restart. Permissions do not sandbox same-user agents or plugins; operators must trust the descriptor and protect its parent directory. Maintainer agreement on this opt-in local trust model is needed. Compiled policy remains non-overridable.
Unix loading rejects symlinks, special files, unexpected ownership and group/world-writable files using the opened handle, with a bounded read. Windows retains its application-data ACL trust model. The file survives session cleanup and local-data wipes. Changes take effect after restart.
Scope after the upstream multi-server changes
Rebased onto
fd21dba; head2eba153. The constructor preserves all compiled servers, their routing and their individual session slots. The local file still supplies only one server, and only when the compiled registry is empty.Standard builds now include
bb-publicand ignore this file. Merging this PR does not let an official download add another organization's server at runtime. The test candidate explicitly setsBUZZ_BUILD_FEDERATED_IDENTITY_CONFIG=''. The docs also cover the existing alternate-Builderlab and pinned-dev rules that produce an empty compiled registry. No additional opt-in flag or runtime overlay of compiled policy is introduced.This does not retarget the bundled Builderlab plugin's compiled grant, first-run account/key linking or backup, and does not grant community membership. An existing Buzz identity and an enforcing NIP-FI relay are required for the tested organization flow. Fresh independent-enterprise signup remains separate. #2245 closed unmerged; #2710 merged explanatory sign-in copy, not the missing fresh-identity flow.
Validation on the rebased source — November 6, 2026
GitHub’s proposed merge
30a882dd7314fd9591dff17554f971df03922a99has exactly the tested head’s source tree (15dc2d4c76dac05df5814fe0cbb7c509e043a9b4). This equivalence is specific to the current snapshot.bb-public, multiple compiled servers, ignoring an invalid local descriptor, routing and stable per-server session slots..appwas built with the pinned toolchain. Build caveat: unchanged upstream main fails TypeScript atsrc/bundled/channels/ChannelsPage.context.test.tsx:248, whosePageNavigationfixture lackspassThrough. I independently reproduced it on cleanfd21dba. For this build only, the fixture gotpassThrough: () => () => {}; its 9 tests then passed. This test-only overlay is excluded from the PR and changes no shipped runtime source. Executable SHA-256:32753befbcd1de2257a0d562c7e74e2c013b5b55cf6b61a70bf411490d451327.codesign --verify --deep --strictreportedcode has no resources but signature indicates they must be present. It was launched directly from the guest Terminal. Normal double-click launch and signed distribution are not validated.Application CI for this head is
action_required. Please approve the hosted run and confirm the local-authority trust-model decision; the earlier approving review explicitly excluded that decision.Earlier live evidence, kept separate
On November 5, head
523fc46and executablef7665806c293caf56a7d0eb459ee3770e39e1261bc452adf3de5243a7215cd4dcompleted this cycle in an Apple silicon VM with an existing Keychain Buzz identity:The contributor's Windows acceptance covers their earlier locally rebased build, not this head. Neither earlier acceptance nor a merge establishes official distribution or fresh-install onboarding.