Repository navigation
Keep hover tooltips and profile previews clear of native apps - #1593
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
nathan-thillairajah
marked this pull request as ready for review
October 23, 2026 22:42
baxen
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering composer controls or a profile avatar beside a native website could hide the whole page. Leaving the page visible exposed a second problem: the native guest covered hover content that crossed the pane divider.
Keep passive tooltips from hiding the website, and bound tooltips and profile previews to their existing conversation pane, including Solo chats. Long hints wrap; enlarged profile previews scroll so their actions remain reachable. Menus and dialogs keep their existing visibility behavior.
Local testing: built and opened the macOS
Buzz PR1593bundle with the existing BBPublic counter app's login page beside a Solo conversation. Nathan verified gauge, Send and avatar hovers: the website stays visible and the hints/cards fit inside the conversation pane. The agent also checked native keyboard access: Tab reaches View profile and Escape restores avatar focus while the website stays visible.The real-control and Solo geometry regressions fail before their fixes. Seven added cases per engine check pane geometry that DOM tests cannot measure. All 32 profile/Apps cases pass in Chromium and WebKit, including narrow/wide panes, both themes, enlarged text and reduced motion. The browser cases substitute native I/O; the packaged-app check above exercises the actual native viewer.
Stack: #1590 (BBPublic app URLs) → #1593 (this PR, native browser hover surfaces).
buzz-review-completed