Repository navigation
Fix opening BBPublic production apps in Buzz - #1590
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
nathan-thillairajah
marked this pull request as ready for review
October 23, 2026 19:50
This was referenced Oct 23, 2026
baxen
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BBPublic production serves apps at
<app>--bpsites.apps.builderlab.xyz. Buzz did not recognize that domain, soapps_openrejected URLs returned by successful deployments and app links missed the embedded viewer.Add the production domain to the existing matcher. Regression coverage checks both tool opening and panel matching, including rejection of lookalike hosts, HTTP URLs and embedded credentials.
The regressions failed before the fix; all 26 focused Apps tests pass afterward. Nathan's local retry opened the viewer and reached the hosted-site login. Interaction with the authenticated app remains unverified.
Stack: #1590 (this PR, BBPublic app URLs) → #1593 (native browser hover surfaces).