Skip to content

ci: add -Wextra-semi to llvm config - #341

Merged
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
fanquake:llvm_extra_semi
Aug 12, 2026
Merged

ci: add -Wextra-semi to llvm config#341
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
fanquake:llvm_extra_semi

Conversation

@fanquake

Copy link
Copy Markdown
Member

Followup to #332

@DrahtBot

DrahtBot commented Aug 12, 2026

Copy link
Copy Markdown

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers
ACK hebasto
Stale ACK ryanofsky

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d44db15.

@DrahtBot

Copy link
Copy Markdown

🐙 This pull request conflicts with the target branch and needs rebase.

@ryanofsky ryanofsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK d44db15

(was about to merge this but it needs rebase after #339)

@fanquake

Copy link
Copy Markdown
Member Author

but it needs rebase after #339)

Rebased.

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK b3b134e.

@DrahtBot
DrahtBot requested a review from ryanofsky August 12, 2026 12:43
@ryanofsky
ryanofsky merged commit 8dab0d4 into bitcoin-core:master Aug 12, 2026
13 checks passed
@fanquake
fanquake deleted the llvm_extra_semi branch August 12, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants