ci: add -Wextra-semi to default config - #332
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsNo conflicts as of last run. |
| }); | ||
| done.get_future().get(); | ||
| KJ_EXPECT(error_thrown); | ||
| KJ_EXPECT(error_thrown) |
There was a problem hiding this comment.
hmm, for macros, I generally prefer if they enforce a trailing semicolon.
Though, it may be too late to fix this now?
There was a problem hiding this comment.
Then perhaps omit -Wextra-semi-stmt?
|
Yea. I don't have too much of an opinion, but it wasn't clear to me why a PR labelled "CI" (#321) was also making random source code changes (bd50831) (although it seems like that PR was generally confusing (#321 (comment))), so thought we could at least make this consistent. |
|
I think 321 was dropping it after a function def, this one is dropping it after statements. |
See #321 (comment). |
Thanks. It would be good to write commit messages that contain information for other contributors (which then persists over time), so they don't have to search through GitHub comments to try and find context/explanations. |
bf3dbbc to
49834b2
Compare
fanquake
changed the title
|
Changed to just add |
4 participants
Follow-up to bd50831.