Repository navigation
Piper voices under both package spellings (AUR last); History grid that really is a grid - #64
Merged
Merged
Conversation
…esort BigLinux stable has piper-voices-pt-br, testing piper-voices-pt-BR: the app asked only for pt-BR, so stable systems were told Piper was not available. - package_installer.resolve() looks for each package under both spellings: an installed one first (both ship the same files, so the other one would fail on file conflicts), then the repositories, and only then the AUR, built as the person with pamac (when its AUR support is on), paru or yay. - The Piper prompt lists where each package comes from and explains AUR. - Voice Manager: one row per voice whatever the spelling (the installed one, else lower case), and "[installed]" read with LC_ALL=C — it was only recognized in Portuguese and English. - README/PKGBUILD name the stable package.
Every card stayed in one column. A wrapping label asks for its whole text on one line, so each card wanted the full width, and the page was clamped to a list's 760 px. - Grid cards have a fixed text width (22 characters): equal columns, as many as fit — 1 on a phone, 2 from ~760 px, 3 on wide windows. - In grid mode the page may grow to 1280 px; back in list mode it is 760. - Rows are as tall as their own tallest card: "Show more" on one card no longer stretches all of them.
fix(piper): find voice packages under both spellings, AUR as a last resort
fix(history): "Show as grid" really shows a grid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes, ruscher/tts-biglinux #15 and #16.
Piper voice packages: both spellings, AUR as a last resort
BigLinux stable has
piper-voices-pt-br, while testing haspiper-voices-pt-BR. The app asked only forpt-BR, so stable systems were told Piper was not available.pamac buildwhen pamac's AUR support is on, otherwiseparuoryaywith--sudo pkexec.LC_ALL=C. It used to be recognized only in Portuguese and English.History: "Show as grid"
Every card stayed in one column: a wrapping label asks for its whole text on one line, and the page was clamped to a list's 760 px.
Verification
LC_ALL=C, as user and as root: 280 passed.makepkgcheck() passed. Installed as1:4.1.0-3. Real package resolution was checked on BigLinux with stable + testing.