Skip to content

Allow jwt v3 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zackgp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow jwt v3 #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## Next Release
Your contribution here.

* [#000](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/000): Brief description here. - [@username](https://github.com/username).
* [#189](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/189): Allow jwt v3 - [@zackgp](https://github.com/zackgp).

## 2.0.0

Expand Down
2 changes: 1 addition & 1 deletion bigcommerce.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ Gem::Specification.new do |s|
s.add_dependency 'faraday', '>= 2.14', '< 3.0'
s.add_dependency 'faraday-gzip', '~> 3.0'
s.add_dependency 'hashie', '>= 3.4', '~> 4'
s.add_dependency 'jwt', '>= 1.5.4', '~> 2'
s.add_dependency 'jwt', '>= 1.5.4', '< 4'
end
8 changes: 8 additions & 0 deletions spec/bigcommerce/unit/resources/customers/customer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,13 @@
expect(payload['iat']).to be <= Time.now.to_i
expect(payload['jti']).to_not be_empty
end

# Regression test for CVE-2026-45363 / GHSA-c32j-vqhx-rx3x, fixed in jwt 3.2.0.
context 'with jwt >= 3.2.0', if: Gem.loaded_specs['jwt'].version >= Gem::Version.new('3.2.0') do
it 'should reject empty/nil HMAC keys' do
expect { JWT.decode(subject, '', true, { algorithm: 'HS256' }) }.to raise_error(JWT::DecodeError)
expect { JWT.decode(subject, nil, true, { algorithm: 'HS256' }) }.to raise_error(JWT::DecodeError)
end
end
end
end