Allow jwt v3 - #189
Open
zackgp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Relax the
jwtdependency constraint in the gemspec from>= 1.5.4, ~> 2to>= 1.5.4, < 4, so consumers can installjwt3.x.jwtgem in this repo (JWT.encode/JWT.decodeinCustomer#login_token). Both calls use the classicpositional API (
HS256algorithm,typheader), which is unchanged andfully supported in
jwt3.x — no breaking API usage was found.customer_spec.rbcoveringCVE-2026-45363
(fixed in
jwt3.2.0):JWT.decodemust reject empty/nil HMAC keys insteadof treating them as a valid signature. The test is scoped to run only when
the resolved
jwtversion is >= 3.2.0, since the gemspec still allowsjwt2.x for backwards compatibility.Tickets / Documentation
Screenshots (if appropriate)
N/A