Skip to content

Harden SMB file editing and transfers - #149

Merged
bifrost0x merged 3 commits into
mainfrom
dev/smb-production-readiness
Aug 26, 2026
Merged

Harden SMB file editing and transfers#149
bifrost0x merged 3 commits into
mainfrom
dev/smb-production-readiness

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • add revision-checked, recoverable SMB text replacement with explicit consent and safe recovery details
  • keep SMB navigation responsive during bulk transfers with separate control and transfer sessions
  • make cancellation idempotent and finalize server-to-server cancellation from the authoritative response
  • surface structured permission, conflict, timeout, availability, and known-size limit errors without exposing sensitive details
  • add same-source Move with no silent overwrite and safe conflict handling
  • expand diagnostics, documentation, unit, browser, and encrypted Samba coverage

Testing

  • Full Python suite: 2,161 passed, 33 skipped
  • Post-review affected Python suites: 150 passed
  • JavaScript unit suite: 330 passed
  • Full Playwright suite: 94 passed
  • Post-review SMB Playwright suite: 8 passed
  • JavaScript lint and vendored asset integrity checks
  • Python dependency lock verification
  • Encrypted SMB 3.1.1 Samba integration stack

Addresses the feedback in Discussion #99: #99

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd4f09cd3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/remote_transfer.py
Comment thread app/socket_events.py
Comment thread static/js/binary-transfer-client.js
@bifrost0x
bifrost0x merged commit 915ba6e into main Aug 26, 2026
16 of 17 checks passed
@bifrost0x
bifrost0x deleted the dev/smb-production-readiness branch August 26, 2026 07:45
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant