Skip to content

Resolve SMB workspace follow-up feedback - #152

Merged
bifrost0x merged 2 commits into
mainfrom
dev/resolve-smb-discussion-followups
Aug 26, 2026
Merged

Resolve SMB workspace follow-up feedback#152
bifrost0x merged 2 commits into
mainfrom
dev/resolve-smb-discussion-followups

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • treat a confirmed cancellation acknowledgement as terminal and keep SFTP browsing responsive by separating transfer channels from control operations
  • make same-source moves visible and report failed, partial, and cancelled upload batches accurately
  • simplify the SMB recovery-save explanation, remember consent per connection, and document TrueNAS/Active Directory UPN usernames
  • restore embedded file toolbar actions after returning from the full file manager
  • update translations, cache versions, documentation, and regression coverage

Follow-up to discussion #99 and PR #149.

Testing

  • Python suite: 2185 passed, 29 skipped; all 4 loopback/socket tests also passed outside the sandbox
  • JavaScript suite: 32 passed
  • Playwright: 27 relevant file-workspace, SMB, and session-workspace tests passed
  • ESLint: passed
  • git diff --check: passed

@bifrost0x
bifrost0x merged commit d335e90 into main Aug 26, 2026
16 of 17 checks passed
@bifrost0x
bifrost0x deleted the dev/resolve-smb-discussion-followups branch August 26, 2026 10:58
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant